-
Notifications
You must be signed in to change notification settings - Fork 19
Pre-release metadata adjustment #574
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@lvicoun Thanks, I found some inconsistencies.
| <meta name="social-descr" its:translate="yes">Perform kernel live patching on &productnameshort;</meta> | ||
| <!-- suitable category, comma-separated list of categories --> | ||
| <meta name="category" content="Systems Management" its:translate="no"/> | ||
| <meta name="category" content="Update&Upgrade" its:translate="no"/> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You need to put it inside a <phrase> and space around the ampersand:
| <meta name="category" content="Update&Upgrade" its:translate="no"/> | |
| <meta name="category" its:translate="no"> | |
| <phrase>Update & Upgrade"</phrase> | |
| </meta> |
articles/podman.asm.xml
Outdated
| <meta name="category" its:translate="no"> | ||
| <phrase>Containers & Virtualization</phrase> | ||
| </meta> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same. Maybe you meant task?
| <meta name="category" its:translate="no"> | |
| <phrase>Containers & Virtualization</phrase> | |
| </meta> | |
| <meta name="task" its:translate="no"> | |
| <phrase>Containerization</phrase> | |
| <phrase>Virtualization</phrase> | |
| </meta> |
articles/pf-bb-config.asm.xml
Outdated
| <meta name="category" its:translate="no"> | ||
| <phrase>Configuration</phrase> | ||
| </meta> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's not a valid value according to Category (Confluence). Maybe you meant task?
| <meta name="category" its:translate="no"> | |
| <phrase>Configuration</phrase> | |
| </meta> | |
| <meta name="task" its:translate="no"> | |
| <phrase>Configuration</phrase> | |
| </meta> |
articles/raid.asm.xml
Outdated
| <meta name="category" its:translate="no"> | ||
| <phrase>Initial Configuration</phrase> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same here:
| <meta name="category" its:translate="no"> | |
| <phrase>Initial Configuration</phrase> | |
| <meta name="task" its:translate="no"> | |
| <phrase>Configuration</phrase> |
articles/saptune.asm.xml
Outdated
| <phrase>Configuration</phrase> | ||
| <phrase>Installation</phrase> | ||
| <phrase>Tuning</phrase> | ||
| <phrase>Performance</phrase> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Neither "Tuning" nor "Performance" is valid for a task.
| <meta name="category" its:translate="no"> | ||
| <phrase>Deployment</phrase> | ||
| </meta> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| <meta name="category" its:translate="no"> | |
| <phrase>Deployment</phrase> | |
| </meta> | |
| <meta name="task" its:translate="no"> | |
| <phrase>Deployment</phrase> | |
| </meta> |
| <meta name="category" its:translate="no"><phrase>Administration</phrase> | ||
| </meta> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| <meta name="category" its:translate="no"><phrase>Administration</phrase> | |
| </meta> | |
| <meta name="task" its:translate="no"> | |
| <phrase>Administration</phrase> | |
| </meta> |
articles/cockpit.asm.xml
Outdated
| <meta name="category" its:translate="no"><phrase>Administration</phrase> | ||
| </meta> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| <meta name="category" its:translate="no"><phrase>Administration</phrase> | |
| </meta> | |
| <meta name="task" its:translate="no"> | |
| <phrase>Administration</phrase> | |
| </meta> |
articles/zram.asm.xml
Outdated
| <meta name="category"> | ||
| <phrase>Systems Management</phrase> | ||
| <phrase>Product Usage</phrase> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is no "Product Usage".
articles/virtualization.asm.xml
Outdated
| <meta name="category"> | ||
| <phrase>Containers & Virtualization</phrase> | ||
| </meta> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You need task:
| <meta name="category"> | |
| <phrase>Containers & Virtualization</phrase> | |
| </meta> | |
| <meta name="task"> | |
| <phrase>Containerization</phrase> | |
| <phrase>Virtualization</phrase> | |
| </meta> |
| </meta> | ||
| <meta name="productname" its:translate="no"> | ||
| <productname version="16.0">&sleha;</productname> | ||
| <productname version="16.0" os="sleha">&productname;;</productname> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| <productname version="16.0" os="sleha">&productname;;</productname> | |
| <productname version="16.0" os="sleha">&productname;</productname> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 💎 Thanks! 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@lvicoun : Many thanks, your changes looked good! I pushed a few more corrections directly, please take a final look and if you are fine with it, we can merge.
- fixed Bugzilla links (wrong assignee mail addresses, wrong component) - titles: shortened some (with productname entity they exceed the char limits), use title style spelling - adjusted meta (social) descriptions (no full stops) - corrected some typos
08c8c3b to
09ead9c
Compare
PR creator: Description
Describe the overall goals of this pull request.
PR creator: Are there any relevant issues/feature requests?
PR reviewer: Checklist for editorial review
Apart from the usual checks, please double-check also the following: