Skip to content

Conversation

@lvicoun
Copy link
Contributor

@lvicoun lvicoun commented Oct 22, 2025

PR creator: Description

Describe the overall goals of this pull request.

PR creator: Are there any relevant issues/feature requests?

  • bsc#...
  • jsc#...

PR reviewer: Checklist for editorial review

Apart from the usual checks, please double-check also the following:

@lvicoun lvicoun added WIP Work in progress. Do not merge! and removed WIP Work in progress. Do not merge! labels Oct 22, 2025
@lvicoun lvicoun requested review from taroth21 and tomschr October 24, 2025 10:54
Copy link
Contributor

@tomschr tomschr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lvicoun Thanks, I found some inconsistencies.

<meta name="social-descr" its:translate="yes">Perform kernel live patching on &productnameshort;</meta>
<!-- suitable category, comma-separated list of categories -->
<meta name="category" content="Systems Management" its:translate="no"/>
<meta name="category" content="Update&amp;Upgrade" its:translate="no"/>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to put it inside a <phrase> and space around the ampersand:

Suggested change
<meta name="category" content="Update&amp;Upgrade" its:translate="no"/>
<meta name="category" its:translate="no">
<phrase>Update &amp; Upgrade"</phrase>
</meta>

Comment on lines 141 to 143
<meta name="category" its:translate="no">
<phrase>Containers &amp; Virtualization</phrase>
</meta>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same. Maybe you meant task?

Suggested change
<meta name="category" its:translate="no">
<phrase>Containers &amp; Virtualization</phrase>
</meta>
<meta name="task" its:translate="no">
<phrase>Containerization</phrase>
<phrase>Virtualization</phrase>
</meta>

Comment on lines 107 to 109
<meta name="category" its:translate="no">
<phrase>Configuration</phrase>
</meta>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's not a valid value according to Category (Confluence). Maybe you meant task?

Suggested change
<meta name="category" its:translate="no">
<phrase>Configuration</phrase>
</meta>
<meta name="task" its:translate="no">
<phrase>Configuration</phrase>
</meta>

Comment on lines 94 to 95
<meta name="category" its:translate="no">
<phrase>Initial Configuration</phrase>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here:

Suggested change
<meta name="category" its:translate="no">
<phrase>Initial Configuration</phrase>
<meta name="task" its:translate="no">
<phrase>Configuration</phrase>

Comment on lines 101 to 102
<phrase>Configuration</phrase>
<phrase>Installation</phrase>
<phrase>Tuning</phrase>
<phrase>Performance</phrase>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Neither "Tuning" nor "Performance" is valid for a task.

Comment on lines 125 to 127
<meta name="category" its:translate="no">
<phrase>Deployment</phrase>
</meta>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<meta name="category" its:translate="no">
<phrase>Deployment</phrase>
</meta>
<meta name="task" its:translate="no">
<phrase>Deployment</phrase>
</meta>

Comment on lines 128 to 129
<meta name="category" its:translate="no"><phrase>Administration</phrase>
</meta>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<meta name="category" its:translate="no"><phrase>Administration</phrase>
</meta>
<meta name="task" its:translate="no">
<phrase>Administration</phrase>
</meta>

Comment on lines 500 to 501
<meta name="category" its:translate="no"><phrase>Administration</phrase>
</meta>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<meta name="category" its:translate="no"><phrase>Administration</phrase>
</meta>
<meta name="task" its:translate="no">
<phrase>Administration</phrase>
</meta>

Comment on lines 112 to 113
<meta name="category">
<phrase>Systems Management</phrase>
<phrase>Product Usage</phrase>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is no "Product Usage".

Comment on lines 49 to 51
<meta name="category">
<phrase>Containers &amp; Virtualization</phrase>
</meta>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need task:

Suggested change
<meta name="category">
<phrase>Containers &amp; Virtualization</phrase>
</meta>
<meta name="task">
<phrase>Containerization</phrase>
<phrase>Virtualization</phrase>
</meta>

</meta>
<meta name="productname" its:translate="no">
<productname version="16.0">&sleha;</productname>
<productname version="16.0" os="sleha">&productname;;</productname>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<productname version="16.0" os="sleha">&productname;;</productname>
<productname version="16.0" os="sleha">&productname;</productname>

@lvicoun lvicoun requested a review from tomschr October 30, 2025 13:33
Copy link
Contributor

@tomschr tomschr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 💎 Thanks! 👍

Copy link
Contributor

@taroth21 taroth21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lvicoun : Many thanks, your changes looked good! I pushed a few more corrections directly, please take a final look and if you are fine with it, we can merge.

lvicoun and others added 11 commits October 30, 2025 16:16
- fixed Bugzilla links (wrong assignee mail addresses, wrong component)
- titles: shortened some (with productname entity they exceed the char
  limits), use title style spelling
- adjusted meta (social) descriptions (no full stops)
- corrected some typos
@lvicoun lvicoun force-pushed the JH_metada_final_check branch from 08c8c3b to 09ead9c Compare October 30, 2025 15:17
@lvicoun lvicoun merged commit 6a630d6 into main Oct 30, 2025
1 check passed
@lvicoun lvicoun deleted the JH_metada_final_check branch October 30, 2025 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants